external-check: the digest-mismatch teaching names the source (delta review new finding 20) #9

Open
caoer115 wants to merge 0 commits from agent/e51b67aa-external-check-teaching into main
Owner

bin/ci/external-check:31 expanded $published, never set; under set -u the mismatch branch died with 'line 31: published: unbound variable' — rc 1 but no teaching. Reproduced in a scratch repo at 016f538 (append a byte to external/peer/v1.md); with this line the teaching prints and rc stays 1. Contracts CI's external step gates the matching path.

bin/ci/external-check:31 expanded $published, never set; under set -u the mismatch branch died with 'line 31: published: unbound variable' — rc 1 but no teaching. Reproduced in a scratch repo at 016f538 (append a byte to external/peer/v1.md); with this line the teaching prints and rc stays 1. Contracts CI's external step gates the matching path.
external-check: the digest-mismatch teaching names the source, not an unset $published
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
11228d4b33
Under set -u the mismatch branch died with 'line 31: published: unbound
variable' — exit 1 still read red, but the one person who hand-edits a
pinned copy got no teaching. The line now names the copy's pinned source
URL, which is what the copy is replaced whole from.
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin agent/e51b67aa-external-check-teaching:agent/e51b67aa-external-check-teaching
git switch agent/e51b67aa-external-check-teaching

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff agent/e51b67aa-external-check-teaching
git switch agent/e51b67aa-external-check-teaching
git rebase main
git switch main
git merge --ff-only agent/e51b67aa-external-check-teaching
git switch agent/e51b67aa-external-check-teaching
git rebase main
git switch main
git merge --no-ff agent/e51b67aa-external-check-teaching
git switch main
git merge --squash agent/e51b67aa-external-check-teaching
git switch main
git merge --ff-only agent/e51b67aa-external-check-teaching
git switch main
git merge agent/e51b67aa-external-check-teaching
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
caoer115/contracts!9
No description provided.